> On Feb. 5, 2017, 8:48 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/windows/fd.hpp, line 59 > > <https://reviews.apache.org/r/54591/diff/7/?file=1624392#file1624392line59> > > > > I'm not super up on the semantics of these newfangled C++11 constructor > > things, but is there any particular reason we need this to be trivially > > constructible, or anything like that? Because, if there's not any > > significant gain, I think it's worth wondering whether having a default > > value is slightly dangerous. > > Michael Park wrote: > We probably don't need triviality, but to support the "Use it just as if > you would an `int`", we do need a default constructor. > If we don't allow default construction, either we don't use `int` on > Linux, or we just live with the fact that Windows builds > break if/when someone tries to say `int_fd fd; ... // initalize later`. I > think I'd rather just let it work. What would you prefer?
Your case is comelling, let's mark it dropped and do as you suggest. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review164273 ----------------------------------------------------------- On Feb. 6, 2017, 1:04 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54591/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 1:04 a.m.) > > > Review request for mesos, Daniel Pravat and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > In POSIX the socket, pipe and a file are represented by the `int` type. > In Windows: > - A socket is kept in a `SOCKET` type (64 bit wide) > - A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide) > - A CRT file descriptor in an `int` > > The `WindowsFD` class is a type that brings all of these things > together and behaves analogously to an `int` in POSIX. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 > 3rdparty/stout/include/stout/os.hpp > ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 > 3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54591/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
