> On Feb. 5, 2017, 12:02 p.m., Jie Yu wrote: > > src/oci/spec.cpp, lines 163-166 > > <https://reviews.apache.org/r/55139/diff/3/?file=1621004#file1621004line163> > > > > what if `digest.isNone()`? > > Qian Zhang wrote: > `digest` is a required field, so it can not be `None()` here. > > Jie Yu wrote: > I'd prefer to be a bit more defensive here, and self contained. Either > add a CHECK here, or doing explicit check of `isNone()`. I prefer the latter.
OK, let me do an explicit check of `isNone()`. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55139/#review164262 ----------------------------------------------------------- On Feb. 6, 2017, 10:43 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55139/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 10:43 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-6681 > https://issues.apache.org/jira/browse/MESOS-6681 > > > Repository: mesos > > > Description > ------- > > Implemented parse methods for OCI image spec. > > > Diffs > ----- > > include/mesos/oci/spec.hpp PRE-CREATION > src/CMakeLists.txt c09bcde3c14a73ab0b296c400f79f6a775da2470 > src/Makefile.am 78d55d86b1e1238beda3163d3240c85609ea982d > src/oci/spec.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/55139/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
