> On Jan. 28, 2017, 1:17 a.m., Vinod Kone wrote: > > src/checks/health_checker.hpp, line 137 > > <https://reviews.apache.org/r/55901/diff/1/?file=1613997#file1613997line137> > > > > we don't typically do `const` for POD types. > > > > s/_agentSpawnsCommandContainer/ > > Gastón Kleiman wrote: > Looks lke the regex was truncated ;-). > > Vinod Kone wrote: > How about "localCommandCheck" (vs "remoteCommandCheck")? > > Alexander Rukletsov wrote: > We are not consistent about `const` that's true, but I think we are > starting to use it more and more often. Unfortunately, I don't have extensive > data at hand, here are some links: > > https://github.com/apache/mesos/blob/30f7f3e1965885406d6d3e49348bee7e7d0df9d5/src/slave/slave.hpp#L970 > > https://github.com/apache/mesos/blob/30f7f3e1965885406d6d3e49348bee7e7d0df9d5/src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp#L55 > > Vinod Kone wrote: > Making a POD member variable const is different from making it a const in > function argument. We definitely do the former but not the latter IIRC. > > Alexander Rukletsov wrote: > Agree.
I'm going with `commandCheckViaAgent` and not marking it `const`. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review163363 ----------------------------------------------------------- On Feb. 8, 2017, 1:27 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55901/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 1:27 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > Added support for command health checks to the default executor. > > > Diffs > ----- > > src/checks/health_checker.hpp 95da1ff7dd6b222a93076633eb3757ec9aa43cf6 > src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > src/tests/health_check_tests.cpp 7b6a803a28b2e4f6c27e9a0c4f668350ec2d5a81 > > Diff: https://reviews.apache.org/r/55901/diff/ > > > Testing > ------- > > Introduced a new test: `HealthCheckTest.DefaultExecutorCmdHealthCheck`. It > passes on Linux, but not on macOS. > > > Thanks, > > Gastón Kleiman > >
