----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56476/#review164922 -----------------------------------------------------------
Fix it, then Ship it! src/common/http.cpp (line 907) <https://reviews.apache.org/r/56476/#comment236750> s/name/httpAuthenticatorName/ Just `name` feels too general. src/common/http.cpp (line 956) <https://reviews.apache.org/r/56476/#comment236751> Not yours, but please indent with 4 spaces. - Jan Schlicht On Feb. 9, 2017, 2:06 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56476/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 2:06 a.m.) > > > Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and > Vinod Kone. > > > Bugs: MESOS-7004 > https://issues.apache.org/jira/browse/MESOS-7004 > > > Repository: mesos > > > Description > ------- > > This patch updates the Mesos code to allow master and agent > to load multiple HTTP authenticator modules. > > > Diffs > ----- > > src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e > > Diff: https://reviews.apache.org/r/56476/diff/ > > > Testing > ------- > > Still need to add tests which test the master and agent with multiple > authenticator modules loaded. > > > Thanks, > > Greg Mann > >
