----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56805/#review166016 -----------------------------------------------------------
Patch looks great! Reviews applied: [56804, 56805] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 18, 2017, 12:14 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56805/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2017, 12:14 a.m.) > > > Review request for mesos, Adam B and Yongqiao Wang. > > > Repository: mesos > > > Description > ------- > > Now that weights can change dynamically, passing a list of weights to > the allocator at initialization-time is unnecessary and confusing (e.g., > the initial weights might be wrong, if a different set of weight values > are recovered from the registry). > > Instead, require that weights are communicated to the allocator via the > existing `updateWeights` method. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 23413d1f9d76009c999b35d2bc98afc52c136404 > src/master/allocator/mesos/allocator.hpp > 38fbf16a0500fc9f6ce7a498a6af3d81d63fc215 > src/master/allocator/mesos/hierarchical.hpp > d33306745a7287b750cb4a5242c7527369d58d65 > src/master/allocator/mesos/hierarchical.cpp > eeb44fe89d4bfd26900b11833c1182157e5c7e5c > src/master/master.cpp 5534674fa2740b0a6e37fc1df34b582f1e691133 > src/tests/allocator.hpp c741a985660e1540ad8e3a9c387d513247e56714 > src/tests/api_tests.cpp 7715da9072e7be81eb19e742857ff7ab3fd60ea5 > src/tests/hierarchical_allocator_tests.cpp > 5441fa9d1fad1ca7819038db49c6d88e40571e4a > src/tests/master_allocator_tests.cpp > 25c67d32eec5fede78eb9fcbc1009eeff7da0dad > src/tests/master_quota_tests.cpp d15c7aacb85596cdee7cf59c0c179247ba624fe5 > src/tests/persistent_volume_endpoints_tests.cpp > ec8df33a3f0d4ad790d5cc753e1691c5517c39c0 > src/tests/reservation_endpoints_tests.cpp > 7432d752120b43560aa96cad8bf3981ee8102e67 > src/tests/reservation_tests.cpp 309ce8b9acc9131110198c14c655427d7fe9d603 > src/tests/resource_offers_tests.cpp > 74dacf140e49e402a4ad02ce7751e7c7b2f78ee1 > src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76 > > Diff: https://reviews.apache.org/r/56805/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
