----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56711/#review166285 -----------------------------------------------------------
Fix it, then Ship it! Looks good; just a couple of minor comments src/slave/containerizer/fetcher.cpp (lines 833 - 838) <https://reviews.apache.org/r/56711/#comment238207> Alphabetize these? src/slave/containerizer/fetcher.cpp (lines 843 - 844) <https://reviews.apache.org/r/56711/#comment238208> If you do `using std::startsWith;` then you could fit these two one one line. - Adam B On Feb. 21, 2017, 3:46 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56711/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 3:46 p.m.) > > > Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann. > > > Bugs: MESOS-6751 and MESOS-7133 > https://issues.apache.org/jira/browse/MESOS-6751 > https://issues.apache.org/jira/browse/MESOS-7133 > > > Repository: mesos > > > Description > ------- > > Fixed fetcher to not pick up environment variables it should not see. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 9ec38dc95dddfcd990369d0146986e20b15da1a0 > > Diff: https://reviews.apache.org/r/56711/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
