----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/#review167448 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Nov. 7, 2016, 4:41 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53330/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 4:41 a.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6451 > https://issues.apache.org/jira/browse/MESOS-6451 > > > Repository: mesos > > > Description > ------- > > This patch added several metrics for docker store: > - a counter for number of layers pulled > - a gauge for total number of layers > - a timer for pull latency distribution in the last hour > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp > 232c027f8f96da0cb30b957bce4607d3695050d2 > src/slave/containerizer/mesos/provisioner/docker/paths.cpp > cd684b33eb308ce1eeb4539a5b2d51985d835db7 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 > > > Diff: https://reviews.apache.org/r/53330/diff/3/ > > > Testing > ------- > > Use mesos-execute to pull several different images, and verified following > counters in agent's metrics/snapshot: > ``` > curl localhost:5051/metrics/snapshot | jq . | grep > containerizer/mesos/docker_pull > "containerizer/mesos/docker_store/layers_pulled": 47, > "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, > "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, > "containerizer/mesos/docker_store/pull_ms/p9999": 12528.3066648832, > "containerizer/mesos/docker_store/pull_ms": 4550.814976, > "containerizer/mesos/docker_store/pull_ms/count": 4, > "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, > "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, > "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, > "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, > "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, > "containerizer/mesos/docker_store/layers": 47, > ``` > > > Thanks, > > Zhitao Li > >
