----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50497/#review167461 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Nov. 14, 2016, 3:40 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50497/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 3:40 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5828 > https://issues.apache.org/jira/browse/MESOS-5828 > > > Repository: mesos > > > Description > ------- > > These constructors take moduleNames as parameter and create > corresponding PIDGroup module while constructing LogProcess. > > > Diffs > ----- > > include/mesos/log/log.hpp d92d7a0b982c1c4bc0fdedde19fe012a6523a224 > src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 > src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 > > > Diff: https://reviews.apache.org/r/50497/diff/5/ > > > Testing > ------- > > see end of review chain. > > > Thanks, > > Jay Guo > >
