----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56666/#review168184 -----------------------------------------------------------
3rdparty/libprocess/src/ssl/utilities.cpp Lines 363 (patched) <https://reviews.apache.org/r/56666/#comment240349> if reason is nullptr the error shows up as "HMAC failed: " which is weird. how about ``` return Error( "HMAC failed" + (reason == nultpr ? "" : ": " + std::string(reason))); ``` - Vinod Kone On March 7, 2017, 3:34 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56666/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 3:34 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > HMAC SHA256 can be used to create or verify message signatures. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/utilities.hpp > c2f64a91a505675d568ddf5aa081125e4e32fe17 > 3rdparty/libprocess/src/ssl/utilities.cpp > 8aec613312eee3dd11d9df8c3828a5185407e073 > > > Diff: https://reviews.apache.org/r/56666/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
