----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57427/ -----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs: MESOS-2824 https://issues.apache.org/jira/browse/MESOS-2824 Repository: mesos Description ------- Added authorization for PULL_CONTAINER_IMAGE agent API call. Diffs ----- include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 include/mesos/authorizer/authorizer.proto fdc4817ce74c45d792fc47f064f7909a83b1657d src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 src/slave/http.cpp bc8209cb81194ebc8b604c9ba0d4a9e176cff2f6 src/tests/api_tests.cpp 52f58a4d6b1ea75744de1c3d2f0f064d9299fe1d src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 Diff: https://reviews.apache.org/r/57427/diff/1/ Testing ------- Added `AuthorizationTest.PullContainerImage` and `AgentAPITest.PullContainerImageUnauthorized` tests. Ran `make check`. Verified manually by starting the agent with `--authenticate_http_readwrite` and sending a call with curl as a principal that is allowed to `pull_container_image`. Thanks, Ilya Pronin