> On March 13, 2017, 12:05 p.m., Alexander Rukletsov wrote: > > src/authorizer/local/authorizer.cpp > > Lines 1005-1017 (patched) > > <https://reviews.apache.org/r/57387/diff/3/?file=1661472#file1661472line1005> > > > > Please do not enclose the `case` block in `{}` for consistency. > > Gastón Kleiman wrote: > This is consistent with the blocks for `ACCESS_SANDBOX`, > `ATTACH_CONTAINER_INPUT`, `ATTACH_CONTAINER_OUTPUT`, `KILL_NESTED_CONTAINER`, > and `REMOVE_NESTED_CONTAINER`. These blocks are however not consistent with > the rest. > > Should I create a patch removing all those extra curly braces? > > Alexander Rukletsov wrote: > Most cases do not enclose its contents in braces (except where it is > necessary as in, e.g., `UPDATE_QUOTA`). Yes, let's clean this up.
Ok, I'll clean this up in a new patch. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57387/#review168752 ----------------------------------------------------------- On March 13, 2017, 2:36 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57387/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 2:36 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie > Yu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-7120 > https://issues.apache.org/jira/browse/MESOS-7120 > > > Repository: mesos > > > Description > ------- > > This new Agent API call makes it possible to destroy the sandbox and > runtime directories of a terminated nested container. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > 2227b241eab1606815fa6464e3d6b1345624fd22 > src/slave/http.cpp bc8209cb81194ebc8b604c9ba0d4a9e176cff2f6 > src/slave/slave.hpp 978edd6309dfbbde1058f9c44d5fac7083ff95fb > src/slave/validation.cpp 3dbd0fa6ec27b38f40c7922c256859b4d29059ac > src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 > src/tests/slave_validation_tests.cpp > 784528443469f68a8f2d93ebdb69dc872eef255d > > > Diff: https://reviews.apache.org/r/57387/diff/5/ > > > Testing > ------- > > The patch contains validation and auth tests that pass on Linux. > > > Thanks, > > Gastón Kleiman > >
