-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57560/#review168822
-----------------------------------------------------------



What's the criteria for deeming such braces necessary or not? Some switch cases 
in authorizer.cpp are left with braces. These cases are long of course, but is 
this the critera used and "how long/complex is too long/complex"?

- Jiang Yan Xu


On March 13, 2017, 11:19 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57560/
> -----------------------------------------------------------
> 
> (Updated March 13, 2017, 11:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary curly braces wrapping case statements.
> 
> 
> Diffs
> -----
> 
>   src/authorizer/local/authorizer.cpp 
> 2227b241eab1606815fa6464e3d6b1345624fd22 
> 
> 
> Diff: https://reviews.apache.org/r/57560/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` in Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Reply via email to