> On March 13, 2017, 9:15 p.m., Jiang Yan Xu wrote: > > include/mesos/authorizer/authorizer.proto > > Lines 174 (patched) > > <https://reviews.apache.org/r/57386/diff/4/?file=1661470#file1661470line174> > > > > The comment above says > > > > ``` > > // NOTE: Values in this enum should be kept in > > // numerical order to prevent accidental aliasing. > > ``` > > > > ?
Good catch! Fixed this in https://reviews.apache.org/r/57593/. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57386/#review168834 ----------------------------------------------------------- On March 10, 2017, 6:02 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57386/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 6:02 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie > Yu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-7120 > https://issues.apache.org/jira/browse/MESOS-7120 > > > Repository: mesos > > > Description > ------- > > Introduced changes to the authz protos needed for RemoveNestedContainer. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > 8389917d12f9a9a3c9b4281f48e23ade14c20528 > include/mesos/authorizer/authorizer.proto > fdc4817ce74c45d792fc47f064f7909a83b1657d > > > Diff: https://reviews.apache.org/r/57386/diff/4/ > > > Testing > ------- > > > Thanks, > > Gastón Kleiman > >