----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/#review168951 -----------------------------------------------------------
include/mesos/authorizer/acls.proto Line 459 (original), 459 (patched) <https://reviews.apache.org/r/57535/#comment241270> Oh, I see this is fixed here. I think it is better to move this change to https://reviews.apache.org/r/57534 src/master/master.hpp Lines 684 (patched) <https://reviews.apache.org/r/57535/#comment241271> s/wehther/whether. src/master/master.hpp Lines 686 (patched) <https://reviews.apache.org/r/57535/#comment241273> nit: s/authorizeSlave/authorizeAgent? src/master/master.cpp Lines 3642 (patched) <https://reviews.apache.org/r/57535/#comment241276> Similar comment as in header file. s/authorizeSlave/authorizeAgent? src/master/master.cpp Line 5372 (original), 5446 (patched) <https://reviews.apache.org/r/57535/#comment241275> nit: Is there a specific reason for the change here (and in reregisterSlave) from `from` to `pid`? - Anindya Sinha On March 14, 2017, 6:27 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57535/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 6:27 p.m.) > > > Review request for mesos, Adam B, Anindya Sinha, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > ------- > > Applied RegisterAgent ACL to the master. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > e75e1879435f1c2bce47a86e9feebf9d051e969b > src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 > src/master/master.cpp d43350d08ddd14fb7ba2a79c899abda6a864038c > src/tests/master_authorization_tests.cpp > 1a0285a3f345ef21a8256d4123d8bb684f538da4 > > > Diff: https://reviews.apache.org/r/57535/diff/2/ > > > Testing > ------- > > make check. > > The tests added here cover some basic scenarios, I have more tests but will > add them when MESOS-7244 is fixed. > > > Thanks, > > Jiang Yan Xu > >
