> On March 14, 2017, 4:05 p.m., Anindya Sinha wrote: > > include/mesos/authorizer/acls.proto > > Line 440 (original), 450 (patched) > > <https://reviews.apache.org/r/57534/diff/2/?file=1664779#file1664779line450> > > > > Not your change, but maybe move that down so the ids are in ascending > > order to avoid issues in future?
Yeah this not being caught by protoc was due to my rebasing. In general ordering is not an issue so I am keep the current order. > On March 14, 2017, 4:05 p.m., Anindya Sinha wrote: > > include/mesos/authorizer/acls.proto > > Lines 459 (patched) > > <https://reviews.apache.org/r/57534/diff/2/?file=1664779#file1664779line459> > > > > `remove_nested_containers` uses 33, so `register_agents` should be 34. Yeah this is my bad rebasing. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review168940 ----------------------------------------------------------- On March 14, 2017, 5:40 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57534/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 5:40 p.m.) > > > Review request for mesos, Adam B, Anindya Sinha, Alexander Rojas, and Greg > Mann. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > ------- > > Added and implemented RegisterAgent ACL. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > e75e1879435f1c2bce47a86e9feebf9d051e969b > include/mesos/authorizer/authorizer.proto > 736f76d552956f2351ffd40fc51d088dff83f8c8 > src/authorizer/local/authorizer.cpp > be8037299601427e5d5e79f58f77eea3f89579d0 > src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f > > > Diff: https://reviews.apache.org/r/57534/diff/3/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >