> On March 16, 2017, 10:42 p.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 54 (patched) > > <https://reviews.apache.org/r/53264/diff/7/?file=1666044#file1666044line56> > > > > `__MESOS_TEST_PORT_MAPPER__`
The `network/cni` isolator looks for `__MESOS_TEST__` to mark it as a test network. So `__MESOS_TEST_PORT_MAPPER__` won't work. We could do `__MESOS_TEST__PORT_MAPPER__` but that looked weird? - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/#review169217 ----------------------------------------------------------- On March 16, 2017, 5:24 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53264/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 5:24 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6022 > https://issues.apache.org/jira/browse/MESOS-6022 > > > Repository: mesos > > > Description > ------- > > Added test for CNI port-mapper plugin. > > > Diffs > ----- > > src/tests/containerizer/cni_isolator_tests.cpp > cb893d3ef005a9cc60c40768fa669b27c4863020 > > > Diff: https://reviews.apache.org/r/53264/diff/7/ > > > Testing > ------- > > sudo ./bin/mesos-tests.sh --gtest_filter=CniIsolator*.* > > > Thanks, > > Avinash sridharan > >
