> On March 24, 2017, 5:22 a.m., Anand Mazumdar wrote: > >
I also changed the name of the flags variable from `agentFlags` to `flags`. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57750/#review169978 ----------------------------------------------------------- On March 24, 2017, 1:07 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57750/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 1:07 p.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch turns off executor authentication in the > ExecutorHttpApiTests, since authentication is not related > to the functionality they are meant to test. Since executor > tokens depend on the FrameworkID/ExecutorID/ContainerID of > the executor, it would be difficult to enable it in these > tests. > > > Diffs > ----- > > src/tests/executor_http_api_tests.cpp > 13d2e1db2ffdad34dadbf2911e91938706fd4fd0 > > > Diff: https://reviews.apache.org/r/57750/diff/6/ > > > Testing > ------- > > `make check` was done to test that all existing tests succeed when executor > authentication is enabled by default in the test cluster code. The > ExecutorHttpApiTests are the only tests in which it has been disabled. > > > Thanks, > > Greg Mann > >
