----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57882/#review170023 -----------------------------------------------------------
src/tests/mock_slave.hpp Lines 118 (patched) <https://reviews.apache.org/r/57882/#comment242758> ` virtual void initialize() override; ` ? src/tests/mock_slave.hpp Lines 206 (patched) <https://reviews.apache.org/r/57882/#comment242753> How about keeping this consistent now that we are using `Owned` on the agent? Use `Option<Owned<>>` instead. Modify the above comment accordingly. src/tests/mock_slave.cpp Lines 156 (patched) <https://reviews.apache.org/r/57882/#comment242756> Use `swap()` instead once it's changed to `Owned`. Also, invoke `reset` on the current pointer after its swapped. - Anand Mazumdar On March 23, 2017, 8:44 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57882/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 8:44 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch adds an overload of `Slave::initialize` to the > mock slave for the purpose of injecting a secret generator. > > > Diffs > ----- > > src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751 > src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf > > > Diff: https://reviews.apache.org/r/57882/diff/2/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
