> On March 28, 2017, 5:44 p.m., Jie Yu wrote: > > src/slave/paths.cpp > > Lines 497-498 (patched) > > <https://reviews.apache.org/r/57911/diff/1/?file=1673979#file1673979line497> > > > > I'll do: > > ``` > > FAIL() << "Unsupported DiskInfo.Source.type"; > > ``` > > Benjamin Bannier wrote: > `FAIL` comes from gtest which is currently not available when compiling > non-test code (e.g., not in the include path). Should I add it? > > I went with `CHECK_NE` here as I saw it used for similar hard checks in > non-test code. It is provided by glog which we use here.
Ah, use LOG(FATAL) then - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57911/#review170321 ----------------------------------------------------------- On March 28, 2017, 6:06 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57911/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 6:06 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > We introduce an explicit UNKNOWN enum kind to allow explicit handling > of unknown enum values (e.g., when the sending and receiving end use > different versions of a message using the enum). > > This commit also migrates pattern matching of values of this enum from > if statements to switch statements so that compiler diagnostics can be > used to identify unhandled cases when other types are added in the > future. > > > Diffs > ----- > > include/mesos/mesos.proto 9a66967ab459f75f21faf21be644f39b3fad670b > include/mesos/v1/mesos.proto 115f1b4d9e129f83a3aed62a95eb11faa12e04d1 > src/common/resources.cpp ca1add1dbbe04fa775004010ebc847254c198bd7 > src/slave/paths.cpp 38ad1993aa36a627ec97a7865488677495ee4c5a > src/slave/slave.cpp c8479d7e8eb915284f0ea8cf75f47acd679dee7e > src/v1/resources.cpp 6008a9d2572d04612f0da2d54834be548d366f29 > > > Diff: https://reviews.apache.org/r/57911/diff/2/ > > > Testing > ------- > > make check (OS X, Linux) > > > Thanks, > > Benjamin Bannier > >
