----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review170353 -----------------------------------------------------------
3rdparty/stout/include/stout/tests/environment.hpp Lines 17-18 (patched) <https://reviews.apache.org/r/57824/#comment243177> Try `__STOUT_TESTS_ENVIRONMENT_HPP__` instead. 3rdparty/stout/include/stout/tests/environment.hpp Lines 196-198 (patched) <https://reviews.apache.org/r/57824/#comment243170> The test filters constitute the main difference between the test environment of Stout vs Libprocess vs Mesos. If we're going to re-use the code effectively, the vector of filters should either be: A) an argument of `Environment` 's constructor; or B) added via a object method (i.e. `Environment::AddFilter(...)`) Doing (A) might result in some rather beefy constructors in Libprocess/Mesos tests. I prefer this approach because it does not add a method that could be mis-used later on. Doing (B) would require moving most of the other logic in the `Environment` constructor into `Environment::SetUp()`. 3rdparty/stout/include/stout/tests/environment.hpp Lines 218-224 (patched) <https://reviews.apache.org/r/57824/#comment243171> You don't have include these two if they are empty. 3rdparty/stout/include/stout/tests/environment.hpp Lines 226-248 (patched) <https://reviews.apache.org/r/57824/#comment243175> Leave this out for now. I have a TODO to move this temporary directory helper out of the `Environment` entirely, so that we don't need a global variable in some of the tests (at the Mesos level). 3rdparty/stout/tests/environment.hpp Lines 1 (patched) <https://reviews.apache.org/r/57824/#comment243173> Delete this file. 3rdparty/stout/tests/environment.cpp Lines 1 (patched) <https://reviews.apache.org/r/57824/#comment243174> Delete this file. - Joseph Wu On March 27, 2017, 3:13 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57824/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 3:13 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-6731 > https://issues.apache.org/jira/browse/MESOS-6731 > > > Repository: mesos > > > Description > ------- > > Filtered stout tests with symlinks when unable to create symlinks. > > > Diffs > ----- > > 3rdparty/stout/include/stout/tests/environment.hpp PRE-CREATION > 3rdparty/stout/tests/environment.hpp PRE-CREATION > 3rdparty/stout/tests/environment.cpp PRE-CREATION > 3rdparty/stout/tests/main.cpp f41b29c087402d5dbed1144504980746e0e9b6da > 3rdparty/stout/tests/os/filesystem_tests.cpp > e445daf9ed4e4c0d44dbb95e1cbebd0342c1acbc > 3rdparty/stout/tests/os/rmdir_tests.cpp > ed43b44663cbf04d7ddb449fd9f42b8de210bc6e > 3rdparty/stout/tests/os_tests.cpp 8b9531443f625ae0e1f00d29e9e45299f181880e > > > Diff: https://reviews.apache.org/r/57824/diff/2/ > > > Testing > ------- > > Ran make check on Linux and the tests on Windows. > > > Thanks, > > John Kordich > >