----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58038/#review170479 -----------------------------------------------------------
Could you add `readability-redundant-string-cstr` to the default `CHECKS` in `support/mesos-tidy.sh`? I am not exactly sure what checks you used in other patches in this chain, could you update their summaries to mention them? - Benjamin Bannier On March 29, 2017, 9:41 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58038/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 9:41 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Spotted via clang-tidy. > > > Diffs > ----- > > src/tests/containerizer/docker_volume_isolator_tests.cpp > 13a1f131973d15225e100b04f8e24c1f9f4d8539 > > > Diff: https://reviews.apache.org/r/58038/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
