----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ -----------------------------------------------------------
(Updated March 31, 2017, 10:18 p.m.) Review request for mesos and Michael Park. Changes ------- Tweak whitespace. Repository: mesos Description ------- The quota'd resources for a nested role are "included" within the quota'd resources for that role's parent. Hence, the quota of a node must always be greater than or equal to the sum of the quota'd resources of that role's children. When creating and removing quota, we must ensure that this invariant is not violated. When computing the cluster capacity heuristic, we must ensure that we do not "double-count" quota'd resources: e.g., if the cluster has a total capacity of 100 CPUs, role "x" has a quota guarantee of 80 CPUs, and role "x/y" has a quota guarantee of 40 CPUs, this does NOT violate the cluster capacity heuristic. Diffs (updated) ----- src/master/quota_handler.cpp 7ff43a048e17b9e9ac0ceed248f7b3fd56b007d6 src/tests/hierarchical_allocator_tests.cpp e343dc37bd7136f0f6dd5dbc22a25cabe715038d src/tests/master_quota_tests.cpp 1714ba13ea63bae05448d0898bf722ef472c672b Diff: https://reviews.apache.org/r/57167/diff/11/ Changes: https://reviews.apache.org/r/57167/diff/10-11/ Testing ------- `make check` Thanks, Neil Conway
