> On March 31, 2017, 6:39 a.m., Michael Park wrote: > > docs/scheduler-http-api.md > > Lines 112 (patched) > > <https://reviews.apache.org/r/58055/diff/1/?file=1680538#file1680538line112> > > > > Hm.. what happened here...? it was just missing before?
It was missing because role has a default of `*`, which reminds me that the MULTI_ROLE capability is needed. > On March 31, 2017, 6:39 a.m., Michael Park wrote: > > docs/scheduler-http-api.md > > Line 183 (original), 184 (patched) > > <https://reviews.apache.org/r/58055/diff/1/?file=1680538#file1680538line184> > > > > Not yours but the indentation is off here.. Yeah, it was all pretty wacky in this file so I tried to leave as is for now. > On March 31, 2017, 6:39 a.m., Michael Park wrote: > > docs/scheduler-http-api.md > > Lines 459-475 (original), 464-481 (patched) > > <https://reviews.apache.org/r/58055/diff/1/?file=1680538#file1680538line464> > > > > Should these be 2-space indented? Yeah, I wasn't sure what was going on with the snippets in this file, they are pretty inconsistent. We should follow up with a cleanup. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58055/#review170670 ----------------------------------------------------------- On March 30, 2017, 1:13 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58055/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 1:13 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-7324 > https://issues.apache.org/jira/browse/MESOS-7324 > > > Repository: mesos > > > Description > ------- > > This also updates the roles documentation to reflect the vision > of roles representing the resource consumer. > > > Diffs > ----- > > docs/authentication.md 1574db981d5f8ddd7d1f6bef1c2b032823d17297 > docs/authorization.md b019120b1dde35d2cd5f613ddc3d6db32715c9ca > docs/persistent-volume.md 410993fb69eb73db6ad17ef361f9b72cba5dc84d > docs/quota.md 931542b37ef398c015e33ca004650b7689e03adf > docs/reservation.md ace5cef4bccb56126a5338ecde04b91c1a90ce58 > docs/roles.md 344a0e375210e5e60e225276b715650dd0934d47 > docs/scheduler-http-api.md 7f808f10a9f71fba44574079238fd6028ff6520c > docs/shared-resources.md 1b490e253447a9e263cb5a6bda10f360ea7138ce > > > Diff: https://reviews.apache.org/r/58055/diff/1/ > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin Mahler > >