> On March 30, 2017, 11:32 a.m., Jan Schlicht wrote: > > include/mesos/v1/mesos.proto > > Lines 1017-1018 (original), 1018-1019 (patched) > > <https://reviews.apache.org/r/58047/diff/1/?file=1680110#file1680110line1019> > > > > Do we also need similar `Block` and `Raw` types/fields here? I.e. a raw > > or block device will also have a mount point.
That depends on what these messages would contain. ATM we have introduced a `Disk` id which might be sufficient. The general idea is to move away from overly specific dedicated messages to a more flexible form. I think this is not an issue ATM - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58047/#review170553 ----------------------------------------------------------- On April 3, 2017, 9:55 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58047/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 9:55 a.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > BLOCK and RAW disk types are low-level disk resources which will need > to be transformed into e.g., volumes by dedicated, still to implement > offer operations. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c > src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a > src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f > src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633 > src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 > > > Diff: https://reviews.apache.org/r/58047/diff/3/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > >
