----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57999/#review170827 -----------------------------------------------------------
src/common/resources.cpp Lines 119 (patched) <https://reviews.apache.org/r/57999/#comment243698> RHS also needs to be checked for `root`. `left.has_root() && right.has_root() && left.root() != right.root()` src/common/resources.cpp Lines 135 (patched) <https://reviews.apache.org/r/57999/#comment243699> See above. src/slave/slave.cpp Lines 385 (patched) <https://reviews.apache.org/r/57999/#comment243702> Let's add a line break before `<<` to reduce jaggedness, like most of these `EXIT(EXIT_FAILURE)` calls do in `Slave::initialize`. src/slave/slave.cpp Lines 403 (patched) <https://reviews.apache.org/r/57999/#comment243703> See above. src/v1/resources.cpp Lines 121 (patched) <https://reviews.apache.org/r/57999/#comment243700> See above, also check `right.has_root()`. src/v1/resources.cpp Lines 137 (patched) <https://reviews.apache.org/r/57999/#comment243701> See above. - Jan Schlicht On March 31, 2017, 11:38 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57999/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 11:38 a.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > This commit is preparation for future changes where path or mount > roots might be calculated lazily, i.e., not known early enough > anymore. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c > src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a > src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f > src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633 > src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 > > > Diff: https://reviews.apache.org/r/57999/diff/3/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > >
