> On April 7, 2017, 1:09 a.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Line 341 (original) > > <https://reviews.apache.org/r/58195/diff/1/?file=1684603#file1684603line341> > > > > why no space?
We seem a bit inconsistent regarding blank lines between cases in `switch` statements, but it looks we tend to avoid them especially for concise cases. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58195/#review171305 ----------------------------------------------------------- On April 4, 2017, 10:24 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58195/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 10:24 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-7275 > https://issues.apache.org/jira/browse/MESOS-7275 > > > Repository: mesos > > > Description > ------- > > From now on executors may implement TCP checks for tasks. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c > src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 > src/common/type_utils.cpp dc0dd71f52581e2067fed279677bda8c82aa7298 > src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299 > src/launcher/executor.cpp bc69beb884d95d1616b2a3d928cdbf00f70f7c88 > src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422 > src/v1/mesos.cpp 5605ff22da77724a7947637bc17e12143ee34802 > > > Diff: https://reviews.apache.org/r/58195/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/58196/ > > > Thanks, > > Alexander Rukletsov > >
