----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57972/#review171377 -----------------------------------------------------------
src/tests/environment.cpp Lines 721-722 (original), 86-90 (patched) <https://reviews.apache.org/r/57972/#comment244269> Instead of moving all those test filters into the header file, why not do this? ``` Environment::Environment(const Flags& _flags) : stout::internal::tests::Environment( std::vector<std::shared_ptr<TestFilter>>{ std::make_shared<AufsFilter>(), std::make_shared<BenchmarkFilter>(), std::make_shared<CfsFilter>(), std::make_shared<CgroupsFilter>(), std::make_shared<CurlFilter>(), std::make_shared<DockerFilter>(), std::make_shared<InternetFilter>(), std::make_shared<LogrotateFilter>(), std::make_shared<NetcatFilter>(), std::make_shared<NetClsCgroupsFilter>(), std::make_shared<NetworkIsolatorTestFilter>(), std::make_shared<NvidiaGpuFilter>(), std::make_shared<OverlayFSFilter>(), std::make_shared<PerfCPUCyclesFilter>(), std::make_shared<PerfFilter>(), std::make_shared<RootFilter>(), std::make_shared<UnzipFilter>(), std::make_shared<XfsFilter>()}), flags(_flags) ``` - Joseph Wu On April 5, 2017, 12:08 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57972/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 12:08 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-6731 > https://issues.apache.org/jira/browse/MESOS-6731 > > > Repository: mesos > > > Description > ------- > > Added base stout Environment class to mesos-tests Environment class. > > > Diffs > ----- > > src/tests/environment.hpp 06b6d54fc76b327e3e26914eb61c16619a36de42 > src/tests/environment.cpp e3cff1847c44bb06bbe898211bfca35cf851217a > src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043 > > > Diff: https://reviews.apache.org/r/57972/diff/2/ > > > Testing > ------- > > Ran make check on Linux and the tests on Windows. > > > Thanks, > > John Kordich > >