> On April 18, 2017, 5:20 p.m., Greg Mann wrote: > > support/test-upgrade.py > > Lines 76-85 (patched) > > <https://reviews.apache.org/r/58357/diff/2/?file=1689457#file1689457line78> > > > > A high level comment: insteads of parametrizing the framework by > > "language", perhaps we could parametrize it by something more generic like > > "framework name". You could use names like "cpp-test-framework", etc. This > > would make it easier to expand this list to include other test frameworks > > from the codebase in the future. What do you think? > > Zhitao Li wrote: > Sounds good. I'll go with this list in the diff: > > - `cpp-test-framework`, > - `java-test-framework`, > - `python-test-framework` > > and we can add more in the future. How does this plan sound?
Sounds good > On April 18, 2017, 5:20 p.m., Greg Mann wrote: > > support/test-upgrade.py > > Lines 164 (patched) > > <https://reviews.apache.org/r/58357/diff/2/?file=1689457#file1689457line166> > > > > Perhaps the default should be to run all of the available test > > frameworks, rather than just one? > > Zhitao Li wrote: > My only concern here is that certain frameworks are more flaky and > subjective to environments broken. For example, both python and java based > test frameworks have been broken from time to time in either my MacOS or > Linux environment (which might be different from the author's). > > As long as the expectation is that user will look into why things are > broken, I'm fine changing this to run all by default, and change the flag to > "exclude some frameworks by name". Yea, fair point. I'd say let's err on the side of caution and run them all by default - this will help expose broken test frameworks and push us to fix them more quickly. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/#review172226 ----------------------------------------------------------- On April 12, 2017, 12:02 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58357/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 12:02 a.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann. > > > Bugs: MESOS-7228 > https://issues.apache.org/jira/browse/MESOS-7228 > > > Repository: mesos > > > Description > ------- > > This patch added support to java and python based test framework in > `test-upgrade.py` script by adding a new option `--lang`. > > > Diffs > ----- > > support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 > > > Diff: https://reviews.apache.org/r/58357/diff/2/ > > > Testing > ------- > > Ran this on all three languages options for cpp, java and python. > > > Thanks, > > Zhitao Li > >
