> On April 19, 2017, 12:12 a.m., James Peach wrote: > > AFAICT the same problem can occur in other places (eg. > > ``StreamingResponseDecoderon_headers_complete``).
James, the patch seems to address both the streaming request/response decoders. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/#review172291 ----------------------------------------------------------- On April 18, 2017, 6:04 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58512/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 6:04 p.m.) > > > Review request for mesos, Anand Mazumdar, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-7400 > https://issues.apache.org/jira/browse/MESOS-7400 > > > Repository: mesos > > > Description > ------- > > If the callback `on_headers_complete()` fails, the decoder's writer > object is `None()`. So, when the callback `on_message_complete()` is > called, we should not crash in that case. > Note that the `CHECK(decoder->writer)` is valid for the callback > `on_body()` is valid since this callback is called only on a success > in `on_headers_complete()` callback. > > > Diffs > ----- > > 3rdparty/libprocess/src/decoder.hpp > 4c779d42548958e610142438a57529ccb4478053 > > > Diff: https://reviews.apache.org/r/58512/diff/1/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
