----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58360/#review172365 -----------------------------------------------------------
src/tests/protobuf_utils_tests.cpp Lines 289 (patched) <https://reviews.apache.org/r/58360/#comment245467> Can you add a comment around why we added this test? src/tests/protobuf_utils_tests.cpp Lines 309 (patched) <https://reviews.apache.org/r/58360/#comment245468> Just do: ```cpp evolve(executorInfo); ``` - Anand Mazumdar On April 19, 2017, 4:23 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58360/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 4:23 p.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-6644 and MESOS-7228 > https://issues.apache.org/jira/browse/MESOS-6644 > https://issues.apache.org/jira/browse/MESOS-7228 > > > Repository: mesos > > > Description > ------- > > Before protobuf 3.2.0, this test would fail because the 64MB limit > imposed by older version of protobuf. > > > Diffs > ----- > > src/tests/protobuf_utils_tests.cpp 5239182812835b93a28e85146b2df2b20ae77328 > > > Diff: https://reviews.apache.org/r/58360/diff/3/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
