> On April 20, 2017, 3:04 a.m., Neil Conway wrote: > > src/tests/sorter_tests.cpp > > Lines 1570 (patched) > > <https://reviews.apache.org/r/58533/diff/1/?file=1694263#file1694263line1570> > > > > I wonder if an iterative solution would be clearer.
I benchmarked both iterative and recursive solutions, and recursive one seems to be much more efficient. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58533/#review172377 ----------------------------------------------------------- On April 20, 2017, 11:54 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58533/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 11:54 a.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7395 > https://issues.apache.org/jira/browse/MESOS-7395 > > > Repository: mesos > > > Description > ------- > > This test is very similar to Sorter_BENCHMARK_Test.FullSort, except > that hierarchical role is built instead of flat one. > > > Diffs > ----- > > src/tests/sorter_tests.cpp 43bd85798aef0c89751b725ebf35308a5e9e997a > > > Diff: https://reviews.apache.org/r/58533/diff/2/ > > > Testing > ------- > > `./bin/mesos-tests.sh --benchmark > --gtest_filter="AgentAndClientCount/HSorter_BENCHMARK_Test.FullSort*"` > > > Thanks, > > Jay Guo > >
