----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ -----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Bugs: MESOS-5937 https://issues.apache.org/jira/browse/MESOS-5937 Repository: mesos Description ------- Fix FlagsFileTest to check for absolute path properly on Windows. Diffs ----- 3rdparty/stout/include/stout/flags/parse.hpp 65edd86372596c2107e9f29cf27301e025e6620e 3rdparty/stout/include/stout/path.hpp 2d2088aadfa1ea82c59424242671c4fb655dede1 3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d Diff: https://reviews.apache.org/r/58673/diff/1/ Testing ------- [==========] Running 2 tests from 1 test case. [----------] Global test environment set-up. [----------] 2 tests from FlagsFileTest [ RUN ] FlagsFileTest.JSONFile [ OK ] FlagsFileTest.JSONFile (3954 ms) [ RUN ] FlagsFileTest.FilePrefix [ OK ] FlagsFileTest.FilePrefix (5 ms) [----------] 2 tests from FlagsFileTest (3959 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test case ran. (3959 ms total) [ PASSED ] 2 tests. Note that I'm having problems testing from Linux right now (see Slack posting to DEV group, April 19th 8:52 AM). I am working on resolving this, but I have no reason to believe that this change would be problematic on Linux. Thanks, Jeff Coffler