----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58706/#review172937 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/tests/version_tests.cpp Line 53 (original), 65 (patched) <https://reviews.apache.org/r/58706/#comment245933> Please add the tagged version back. - Kapil Arya On April 25, 2017, 11:09 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58706/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 11:09 a.m.) > > > Review request for mesos, Benjamin Mahler and Kapil Arya. > > > Bugs: MESOS-1987 > https://issues.apache.org/jira/browse/MESOS-1987 > > > Repository: mesos > > > Description > ------- > > Switch to table-based test cases, validate that version parsing produces > the expected results more precisely. > > > Diffs > ----- > > 3rdparty/stout/tests/version_tests.cpp > 724ed2292fdd3c5f4c98facf82260078b66a0e97 > > > Diff: https://reviews.apache.org/r/58706/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
