> On April 26, 2017, 7:28 p.m., Jie Yu wrote: > > Have you tested with all registries that we support?
I've run the unit tests, which should cover all supported public registries. Also manually tested on a local private registry and Amazen ECR. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/#review173083 ----------------------------------------------------------- On April 26, 2017, 6:20 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58725/ > ----------------------------------------------------------- > > (Updated April 26, 2017, 6:20 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7427 > https://issues.apache.org/jira/browse/MESOS-7427 > > > Repository: mesos > > > Description > ------- > > Added 'Accept: application/vnd.docker.distribution.manifest.v1+json' > to the headers of HTTP requests for fetching manifests from any Docker > registry. Some registry services (e.g., Amazon ECR) check the 'Accept' > field strictly and reject the requests if it is not specified. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 > > > Diff: https://reviews.apache.org/r/58725/diff/2/ > > > Testing > ------- > > sudo make check > Manually tested on a local docker private registry and an Amazon ECR > repository. > > > Thanks, > > Chun-Hung Hsiao > >
