> On April 11, 2017, 10:17 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp > > Lines 94-95 (original), 94-95 (patched) > > <https://reviews.apache.org/r/57652/diff/1/?file=1665547#file1665547line94> > > > > I don't think either of these fields should be used to return a > > redirect. If we want to allow an authenticator module to return a > > (temporary) redirect, then we should a) add a new redirect field to the > > struct, and b) teach any users of the http authenticator (i.e. master, > > agent, etc.) to handle/log such a result and return the appropriate > > response.
I completely agree with adam's view. We should probably add an `Option<Redirect> redirect` field instead of making the existing ones `Option<Response>`. Note that this was done on purpose so authenticators just have a limited set of actions it can take, therefore not being allowed to do anything but authorization. Moreover, transforming the fields to `Option<Response>` can allow very weird things to be done like `unauthorized` suddenly containing an `OK` message. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57652/#review171529 ----------------------------------------------------------- On April 5, 2017, 9:13 p.m., Silas Snider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57652/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 9:13 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Alexander Rojas, and Greg > Mann. > > > Bugs: MESOS-7247 > https://issues.apache.org/jira/browse/MESOS-7247 > > > Repository: mesos > > > Description > ------- > > Previously only allowed Unauthorized/Forbidden. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/authenticator.hpp > 272d92117547512328c09dfc04c6ca4bf7b6b937 > > > Diff: https://reviews.apache.org/r/57652/diff/1/ > > > Testing > ------- > > > Thanks, > > Silas Snider > >
