----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58847/#review173337 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/paths.hpp Lines 47 (patched) <https://reviews.apache.org/r/58847/#comment246356> I'd remove CONTAINER prefix: ``` constexpr char LAUNCH_INFO_FILE[] = "launch_info"; ``` - Jie Yu On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58847/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 4:14 p.m.) > > > Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > In mesos containerizer, cache each container's launch info and > recover it for non-orphan containers. This is a prerequisite for > persisting some container characteristics across agent failover. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > b58baed64480e22f640a4852537f85922ed382ae > src/slave/containerizer/mesos/paths.hpp > d85fd34660faacd9c73de2ba7b87b3bbd4b6007b > src/slave/containerizer/mesos/paths.cpp > ed4bbd2491e71ad1e4a41e0575b514377d02da9b > > > Diff: https://reviews.apache.org/r/58847/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/58718/ > > > Thanks, > > Alexander Rukletsov > >
