----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review173669 -----------------------------------------------------------
src/cli_new/lib/cli/tests/base.py Lines 116-117 (patched) <https://reviews.apache.org/r/58720/#comment246696> We should not end strings with a space (i.e. "something "). The space should always begin on the next line. Also, we should try and balance the string across the two lines, i.e.: ``` if Master.count > 0: raise CLIException("Creating more than one master" " is currently not possible") ``` src/cli_new/lib/cli/tests/base.py Lines 165-168 (patched) <https://reviews.apache.org/r/58720/#comment246695> Let's pull these constants out into module variables. ``` DEFAULT_MASTER_IP = 127.0.0.1 DEFAULT_MASTER_PORT = 9090 DEFAULT_AGENT_IP = 127.0.0.1 DEFAULT_AGENT_PORT = 9091 ``` src/cli_new/lib/cli/tests/base.py Lines 177 (patched) <https://reviews.apache.org/r/58720/#comment246697> Here too. src/cli_new/lib/cli/tests/base.py Lines 257 (patched) <https://reviews.apache.org/r/58720/#comment246701> here too src/cli_new/lib/cli/tests/base.py Lines 386 (patched) <https://reviews.apache.org/r/58720/#comment246702> Let's use the `os.path.join` here. - Kevin Klues On April 25, 2017, 10:18 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58720/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 10:18 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7283 > https://issues.apache.org/jira/browse/MESOS-7283 > > > Repository: mesos > > > Description > ------- > > This infrastructure includes the ability to bring up a test cluster to > run the CLI against. Future unit tests will use this infrastructure to > test their commands against a running mesos cluster. The tests require > some binaries created when building Mesos. > > > Diffs > ----- > > src/cli_new/lib/cli/tests/__init__.py PRE-CREATION > src/cli_new/lib/cli/tests/base.py PRE-CREATION > src/cli_new/lib/cli/tests/tests.py PRE-CREATION > src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 > src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 > > > Diff: https://reviews.apache.org/r/58720/diff/1/ > > > Testing > ------- > > PEP8 and Pylint used to make sure that the code style is correct. Manuel test: > > $ cd src/cli_new > $ ./bootstrap > $ source activate > > (mesos-cli) $ mesos-cli-tests > > > Thanks, > > Armand Grillet > >