----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/ -----------------------------------------------------------
(Updated May 8, 2017, 7:03 p.m.) Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu. Changes ------- Addressed Jie's comment. Bugs: mesos-7374 https://issues.apache.org/jira/browse/mesos-7374 Repository: mesos Description ------- Checked if the 'filesystem/linux' isolator is enabled and the 'linux' launcher is used when launching a mesos containerizer with an image under Linux. This prevents the executor from messing up with the host filesystem. The check is in `MesosContainerizerProcess::prepare()` after provisioning and before launching, since provisioning itself does not depend on the filesystem isolator. Also checked that the 'filesystem/linux' is enabled and the 'linux' launcher is used when enabling the 'docker/runtime' isolator. Diffs (updated) ----- src/slave/containerizer/mesos/containerizer.cpp 58ab74571fb14c6dbb1907151dc421f93e324bb5 src/slave/containerizer/mesos/isolators/docker/runtime.cpp 2a6e0b179394e0485d2495ceb4bbbcb184af08fe src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137 src/tests/containerizer/mesos_containerizer_tests.cpp 13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4 Diff: https://reviews.apache.org/r/58939/diff/4/ Changes: https://reviews.apache.org/r/58939/diff/3-4/ Testing ------- sudo make check Manually tested on a simplified case of mesos-7374. Thanks, Chun-Hung Hsiao