> On May 8, 2017, 8:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/paths.cpp > > Lines 210 (patched) > > <https://reviews.apache.org/r/59061/diff/1/?file=1710774#file1710774line210> > > > > Why `isdir`? not os::exists? > > Gilbert Song wrote: > Following the patern in this file. We are only using `stat::isdir` in > this helper file. I guess you want me to fix all? > > Chun-Hung Hsiao wrote: > I perfor the more specific `isdir` check here if the `rootfs` file is > always a directory in all scenarios we want to ignore.
OK. i don't realized that all existence check in this file uses 'isdir' - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59061/#review174225 ----------------------------------------------------------- On May 8, 2017, 7:51 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59061/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 7:51 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jie Yu, Michael Park, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-7471 > https://issues.apache.org/jira/browse/MESOS-7471 > > > Repository: mesos > > > Description > ------- > > In provisioner recover, when listing the container rootfses, it is > possible that the 'rootfses' dir does not exist. Because a possible > race between the provisioner destroy and the agent restart. For > instance, while the provisioner is destroying the container dir the > agent restarts. Due to os::rmdir() is recursive by traversing the > FTS tree, it is possible that 'rootfses' dir is removed but the > others (e.g., scratch dir) are not. > > Currently, we are returning an error if the 'rootfses' dir does not > exist, which blocks the agent from recovery. We should skip it if > 'rootfses' does not exist. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/paths.cpp > d2de98b66b7cf8331e82c31d0602dfe7e77d2130 > > > Diff: https://reviews.apache.org/r/59061/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
