> On May 8, 2017, 8:03 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 226 (patched) > > <https://reviews.apache.org/r/59000/diff/4/?file=1711004#file1711004line226> > > > > should this be "environment/secret" instead? i'm assuming there might > > be other env based isolators in the future.
Jie suggested that we keep it at the top-level. This is also an special case where this isolator is not visible outside and is turned on by default. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/#review174246 ----------------------------------------------------------- On May 9, 2017, 2:11 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59000/ > ----------------------------------------------------------- > > (Updated May 9, 2017, 2:11 p.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added environment secret isolator. > > > Diffs > ----- > > src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 > src/slave/containerizer/mesos/containerizer.cpp > 58ab74571fb14c6dbb1907151dc421f93e324bb5 > src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION > src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 > src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59000/diff/5/ > > > Testing > ------- > > Added a new test and ran `make check`. > > > Thanks, > > Kapil Arya > >
