----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58821/#review174378 -----------------------------------------------------------
src/tests/check_tests.cpp Lines 706-730 (patched) <https://reviews.apache.org/r/58821/#comment247506> I wonder if it might be better to improve the check command instead of doing this (is there a guarantee that the file exists by the second check update?) For example the check command could wait until the file exists in a while loop and we can rely on the check timeout to break the loop incase of a failure. - Vinod Kone On May 9, 2017, 2:32 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58821/ > ----------------------------------------------------------- > > (Updated May 9, 2017, 2:32 p.m.) > > > Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7433 > https://issues.apache.org/jira/browse/MESOS-7433 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35 > > > Diff: https://reviews.apache.org/r/58821/diff/4/ > > > Testing > ------- > > `make check` on Mac OS and Fedora 24 > > > Thanks, > > Alexander Rukletsov > >
