> On May 11, 2017, 12:38 a.m., Benjamin Mahler wrote: > > Ok, I understand now what's going on in this change. I gave some > > suggestions for comments / naming to clarify this. > > > > It feels like a hack however, since I would expect the breadcrumb '/' > > characters to be getting copied. Do you understand why they're not getting > > copied? If not, please leave a TODO to look into that.
Thx @bmahler, > why they're not getting copied? As I mentioned in https://issues.apache.org/jira/browse/MESOS-7468 , this is expected here because the definition of breadcrumb in bootstrap is ``` .breadcrumb > li + li:before { content: "/"; } ``` `:before` selector make that content not getter copied here. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review174590 ----------------------------------------------------------- On May 8, 2017, 8:01 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58874/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 8:01 a.m.) > > > Review request for mesos, Benjamin Mahler and Tomasz Janiszewski. > > > Bugs: MESOS-7468 > https://issues.apache.org/jira/browse/MESOS-7468 > > > Repository: mesos > > > Description > ------- > > Stripped spaces between directory elements in WebUI. > > > Diffs > ----- > > src/webui/master/static/browse.html > b9849197227b06df348789a49348e2b5d4cfd2ae > src/webui/master/static/css/mesos.css > 9f3de5427071fc61d3791c4bc2a660368c2cd3c2 > > > Diff: https://reviews.apache.org/r/58874/diff/3/ > > > Testing > ------- > > > File Attachments > ---------------- > > strip_space.gif > > https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif > > > Thanks, > > haosdent huang > >
