----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/#review175055 -----------------------------------------------------------
Patch looks great! Reviews applied: [59194, 59195, 58486] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 15, 2017, 6:01 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58486/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 6:01 p.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-7308 > https://issues.apache.org/jira/browse/MESOS-7308 > > > Repository: mesos > > > Description > ------- > > The allocator is updated for each offer operation in the order specified > in the `ACCEPT` call. Once the allocator is updated successfully, we > handle subsequent operations as follows: > > 1) Launch or Launch Group: We launch the tasks or task group on the > agent. > 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send > the `CheckPointResourcesMessage` to the agent. > > If allocation for any of the operations fail, those resources are not > recovered from the allocator. > > > Diffs > ----- > > src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 > src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad > > > Diff: https://reviews.apache.org/r/58486/diff/6/ > > > Testing > ------- > > Tests passed. > > > Thanks, > > Anindya Sinha > >
