> On April 27, 2017, 7:58 a.m., Alexander Rojas wrote: > > src/master/http.cpp > > Lines 3481-3482 (original), 3456-3457 (patched) > > <https://reviews.apache.org/r/58095/diff/4/?file=1693998#file1693998line3495> > > > > Not yours, but I feel the formatting of this lambda is really off. The > > body of the lambda starts a couple of columns earlier than declaration. > > Jay Guo wrote: > Other indents in this file are off too, e.g. `state()`, `frameworks()` > > Alexander Rojas wrote: > I see, we should open a JIRA ticket requesting to fix those wrong > formattings.
I didn't see a link to a new JIRA for this yet. If it's easier, you can just do a follow-up patch, but let's not let bad style spread/linger. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review173186 ----------------------------------------------------------- On May 10, 2017, 9:32 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58095/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 9:32 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Benjamin Mahler, and > Michael Park. > > > Bugs: MESOS-4732 and MESOS-7260 > https://issues.apache.org/jira/browse/MESOS-4732 > https://issues.apache.org/jira/browse/MESOS-7260 > > > Repository: mesos > > > Description > ------- > > Refactored `Master::Http::roles` to use `jsonify`. > > > Diffs > ----- > > src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e > src/common/http.cpp 167dce2b9a2d3b68a1df5b4079f701482d34db28 > src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31 > > > Diff: https://reviews.apache.org/r/58095/diff/7/ > > > Testing > ------- > > no functional changes > make check > > > Thanks, > > Jay Guo > >
