----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/#review175218 -----------------------------------------------------------
Also need a test for the v1 API authz changes in https://reviews.apache.org/r/58099 src/tests/master_authorization_tests.cpp Lines 2148 (patched) <https://reviews.apache.org/r/58097/#comment248646> s/frameworks under a roles is/frameworks under a role are/ src/tests/master_authorization_tests.cpp Lines 2226 (patched) <https://reviews.apache.org/r/58097/#comment248648> Please validate the single role name is as expected. - Adam B On May 10, 2017, 6:47 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58097/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 6:47 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler. > > > Bugs: MESOS-7260 > https://issues.apache.org/jira/browse/MESOS-7260 > > > Repository: mesos > > > Description > ------- > > Added a test to check framework filtering in /roles endpoint. > > > Diffs > ----- > > src/tests/master_authorization_tests.cpp > e4233c19b1d9e3e2734259503d0daec4ce243667 > > > Diff: https://reviews.apache.org/r/58097/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
