> On May 17, 2017, 9:57 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/cmake/Versions.cmake > > Line 31 (original), 31 (patched) > > <https://reviews.apache.org/r/58515/diff/3/?file=1722583#file1722583line31> > > > > If 3.2.0 compiles on Windows then we can resolve MESOS-3453.
If we want to address this then `3rdparty/CMakeList.txt` needs corresponding changes. Or maybe address this in another RR? - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58515/#review175319 ----------------------------------------------------------- On May 17, 2017, 3:47 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58515/ > ----------------------------------------------------------- > > (Updated May 17, 2017, 3:47 a.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Bugs: MESOS-7228 > https://issues.apache.org/jira/browse/MESOS-7228 > > > Repository: mesos > > > Description > ------- > > Update 3rdparty build to support protobuf 3.2.0. > > > Diffs > ----- > > 3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e > 3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd > > > Diff: https://reviews.apache.org/r/58515/diff/3/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >