> On May 19, 2017, 10:04 a.m., Alexander Rukletsov wrote: > > src/launcher/default_executor.cpp > > Lines 795-797 (original), 795-799 (patched) > > <https://reviews.apache.org/r/59375/diff/1/?file=1724147#file1724147line795> > > > > Why do you think the reason here should be updated task health? This > > update is sent for the finished task, so the reason is more "task > > finished". We do include health information here, but I'm not sure we > > should modify the reason.
After the discussion with AlexR, we've decided to consider specifying appropriate status update reason, meaning that the task was killed due to a failing health check. Something like TaskStatus::REASON_TASK_KILLED_AFTER_FAILING_HEALTH_CHECK. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59375/#review175482 ----------------------------------------------------------- On May 19, 2017, 9:07 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59375/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 9:07 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-6905 > https://issues.apache.org/jira/browse/MESOS-6905 > > > Repository: mesos > > > Description > ------- > > This gives clear indication about the reason of task status updates > caused by task health update. > > > Diffs > ----- > > include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154 > include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3 > src/docker/executor.cpp 82ae9bdc94565acb746724c2e6ab6432aa6bd751 > src/launcher/default_executor.cpp 5c31f948b5ba470e7c007c39e1c0c903451477e2 > src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 > src/tests/check_tests.cpp 3607a690c963a84acfb2d3adc6c4a4f148b456d6 > src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad > > > Diff: https://reviews.apache.org/r/59375/diff/3/ > > > Testing > ------- > > Added checks for task status updates caused by task health update. > > make check (fedora 25, mac os 10.12) > > > Thanks, > > Andrei Budnik > >
