----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59463/#review175720 -----------------------------------------------------------
src/tests/slave_recovery_tests.cpp Lines 891-898 (patched) <https://reviews.apache.org/r/59463/#comment249072> This needs to advance and wait for each ping, otherwise it only leads to 1 ping being fired. You can find some examples: $ grep -R PingSlaveMessage src/tests $ grep -R PongSlaveMessage src/tests - Benjamin Mahler On May 22, 2017, 9:17 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59463/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 9:17 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone. > > > Bugs: MESOS-7540 > https://issues.apache.org/jira/browse/MESOS-7540 > > > Repository: mesos > > > Description > ------- > > This patch adds a new test, `SlaveRecoveryTest.PingTimeoutDuringRecovery`, > which verifies that the agent will reply to pings from the master while it > is performing recovery. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 > > > Diff: https://reviews.apache.org/r/59463/diff/1/ > > > Testing > ------- > > `GTEST_FILTER="*PingTimeoutDuringRecovery*" bin/mesos-tests.sh > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
