----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58905/#review175735 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On May 19, 2017, 10:14 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58905/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 10:14 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-7449 > https://issues.apache.org/jira/browse/MESOS-7449 > > > Repository: mesos > > > Description > ------- > > The choice of naming scheme is cosmetic. All versions of the Docker > containerizer will consider containers starting with "mesos-" > as containers started by Mesos. The Docker containerizer does not > consider the `SlaveID` at all when recovering. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3 > src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 > > > Diff: https://reviews.apache.org/r/58905/diff/2/ > > > Testing > ------- > > See last patch in chain. > > TODO: Add a backwards compatibility test . > > > Thanks, > > Joseph Wu > >