> On May 25, 2017, 3:16 a.m., Kevin Klues wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 216 (patched) > > <https://reviews.apache.org/r/58720/diff/10/?file=1731962#file1731962line216> > > > > We need to be consistent here. If all functions in this file that we > > pass to `get_json` can be written as lambda's then we can write them all as > > lambdas (though I'd argue that it's less readable this way). > > > > If even one can't be written as a lambda (e.g. it requires an if > > statement inside of it), we should avoid using lambdas everywhere.
As a project, we tend to prefer consistency and readability over conciseness and efficiency (especially in places where it's not a huge bottleneck). - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176035 ----------------------------------------------------------- On May 24, 2017, 1:28 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58720/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 1:28 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7283 > https://issues.apache.org/jira/browse/MESOS-7283 > > > Repository: mesos > > > Description > ------- > > This infrastructure includes the ability to bring up a test cluster to > run the CLI against. Future unit tests will use this infrastructure to > test their commands against a running mesos cluster. The tests require > some binaries created when building Mesos. > > > Diffs > ----- > > src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb > src/cli_new/lib/cli/tests/__init__.py PRE-CREATION > src/cli_new/lib/cli/tests/base.py PRE-CREATION > src/cli_new/lib/cli/tests/constants.py PRE-CREATION > src/cli_new/lib/cli/tests/tests.py PRE-CREATION > src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 > src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 > > > Diff: https://reviews.apache.org/r/58720/diff/10/ > > > Testing > ------- > > PEP8 and Pylint used to make sure that the code style is correct. Manuel test: > > $ cd src/cli_new > $ ./bootstrap > $ source activate > > (mesos-cli) $ mesos-cli-tests > > > Thanks, > > Armand Grillet > >